Remove duplicate LICENSE and NOTICE files from benchmark JARs
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- java
- Domain
- build-system
Research direction
Inspect the shade configuration in the parquet-benchmarks and parquet-plugins/parquet-plugins-benchmarks modules. Run ./mvnw --batch-mode -Pvector-plugins -DskipTests clean package, then inspect the final benchmark JARs with the provided checks. Done means each final JAR contains exactly one META-INF/LICENSE and one META-INF/NOTICE while retaining required attribution.
Written by the indexing model from the issue text.
Description
Similar to https://github.com/apache/iceberg/issues/17406
These local JMH artifacts are not published, so releases are unaffected. Update their shade configuration to retain only the intended META-INF/LICENSE and META-INF/NOTICE, while preserving required attribution in those canonical files.
The shaded benchmark uber-JARs contain multiple LICENSE/NOTICE variants:
parquet-benchmarks.jarparquet-plugins-benchmarks.jar
Reproduction
# Build all default and vector-plugin JARs without running tests.
./mvnw --batch-mode -Pvector-plugins -DskipTests clean package
# Check all final JARs; exclude only Maven Shade backup artifacts.
(
failed=0
while IFS= read -r -d '' jar; do
licenses=$(jar tf "$jar" | grep -Eic '(^|/)LICENSE([._-].*)?$' || true)
notices=$(jar tf "$jar" | grep -Eic '(^|/)NOTICE([._-].*)?$' || true)
if [ "$licenses" -eq 1 ] && [ "$notices" -eq 1 ]; then
echo "PASS: $jar"
else
echo "FAIL: $jar (LICENSE=$licenses, NOTICE=$notices)"
jar tf "$jar" | grep -Ei '(^|/)(LICENSE|NOTICE)([._-].*)?$'
failed=1
fi
done < <(
# original-* JARs are temporary backups created by Maven Shade.
find . -type f -path '*/target/*.jar' \
! -name 'original-*.jar' \
-print0 | sort -z
)
exit "$failed"
)
Observed failures:
FAIL: ./parquet-benchmarks/target/parquet-benchmarks.jar (LICENSE=9, NOTICE=4)
FAIL: ./parquet-plugins/parquet-plugins-benchmarks/target/parquet-plugins-benchmarks.jar (LICENSE=4, NOTICE=3)
Expected: every final JAR contains exactly one LICENSE and one NOTICE file under META-INF/.
- Dominant language
- Java
- Stars
- 3.1k
- Forks
- 1.6k
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 28
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/parquet-java
-
Type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/parquet-java#3792 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
apache/parquet-java#3767 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/parquet-java#3667 ·
-
Type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/parquet-java#3587 ·
-
Type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/parquet-java#3574 · 1 comment ·
All issues in apache/parquet-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
elastic/gradle-plugins#157 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cryptomator/hub#497 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
johanhaleby/occurrent#1120 ·