apache/openwhisk

"Too many concurrent requests in flight" error message is misleading

Open

#4,798 opened on Jan 12, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (6,777 stars) (1,177 forks)batch import
good first issue

Description

@ali-raza-tariq commented on Fri Jan 10 2020

The existing implementation shows the following error message when inflight limit is exceeded

<Response [429]> b'{\n  "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n  "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'

Few suggestions:

The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)

So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)

Contributor guide

Tech stack
scala
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of OpenWhisk architectureScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The error message is generated in the controller code, likely in the file that handles concurrency limits (e.g., LoadBalancer or ActivationThrottle). The issue suggests changing the 'allowed' field to reflect the user set actionInvokesConcurrent limit or total allowed across controllers. A fix should update the error message string to clarify that the allowed count is per controller, or compute the total allowed. The variable 'allowed' is currently set to the per controller limit; a better approach might be to display both per controller and total limits. Since there are no linked PRs or comments, maintainer input is needed to confirm the desired approach.
"Too many concurrent requests in flight" error message is misleading · apache/openwhisk#4798 | Good First Issue