apache/openwhisk

Inconsistent error when retrieving a package bound to deleted package

Open

#4,130 opened on Nov 21, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (1,177 forks)batch import
APIcontrollergood first issuehelp wanted

Repository metrics

Stars
 (6,777 stars)
PR merge metrics
 (Avg merge 17h 31m) (3 merged PRs in 30d)

Description

Environment details:

  • local ansible deployment
  • version of docker, vagrant, ubuntu, ...
→ docker -v
Docker version 18.06.1-ce, build e68fc7a
→ docker-compose -v
docker-compose version 1.15.0, build e12f3b9
→ uname -a
Linux blob 4.10.0-38-generic #42~16.04.1-Ubuntu SMP Tue Oct 10 16:32:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Steps to reproduce the issue:

  1. Create package p
wsk package create p
  1. Create package with binding b to package p
wsk package bind p b
  1. Delete package p
wsk package delete p
  1. Get package with binding b
wsk package get b

Provide the expected results and outputs:

$ wsk package get b
error: Unable to get package 'b': Binding references a package that does not exist. (code OTmOOcCT5v8luUz68hlVb8DDPpVHpGya)

Provide the actual results and outputs:

$ wsk package get b
error: Unable to get package 'b': The requested resource 'guest/b' does not exist. (code OTmOOcCT5v8luUz68hlVb8DDPpVHpGya)

Additional information you deem important:

  • Uncovered by @rabbah in PR #4122

Contributor guide

Research direction
Locate the error handling code for package retrieval in the backend. Look for where the binding's reference is checked and ensure the appropriate error message is returned when the bound package is deleted.
Tech stack
scala
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75