apache/openwhisk

do not base64 encode __ow_body for raw web actions

Open

#3,920 opened on Jul 30, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Scala (1,177 forks)batch import
controllergood first issuehelp wanted

Repository metrics

Stars
 (6,777 stars)
PR merge metrics
 (Avg merge 17h 31m) (3 merged PRs in 30d)

Description

#3919 removes the base64 encoding requirement when returning JSON as string (and setting the content-type). However we continue to encode JSON for raw http actions receiving __ow_body. For symmetry, we should stop doing that as well. This is largely in place for legacy reasons (spray vs akka). The net of this change is that functions would JSON.parse(param.__ow_body) instead of JSON.parse(decode64(param.__ow_body)).

Contributor guide

Research direction
Identify where base64 encoding is applied to ow body in raw HTTP actions and remove it, ensuring symmetry with JSON string handling.
Tech stack
scala
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70