apache/openwhisk

WskRestOperation implements action create with copy but it should not

Open

#3846 opened on Jul 6, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (6,777 stars) (1,177 forks)batch import
help wantedtesting

Description

The copy operation is a function of the cli, not the rest api. So supporting a copy in the WskRestOperation's implementation of wsk.action.create doesn't make sense.

https://github.com/apache/incubator-openwhisk/blob/3ab604c167ac5bec76c756e3e76473863eb0a25d/tests/src/test/scala/common/rest/WskRestOperations.scala#L332

The code should be removed and any rest tests in place should be moved strictly to the cli tests. It's arguable we should preserve this behavior --- if we reify this implementation into a scala SDK for openwhisk. Otherwise, I'm not sure why we should support this.

Contributor guide

Tech stack
scala
Domain
apicli
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Scala basicsUnderstanding of OpenWhisk CLI vs API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue points to a specific file: tests/src/test/scala/common/rest/WskRestOperations.scala. The task is to remove the copy operation from the `wsk.action.create` implementation in WskRestOperations and ensure that any REST tests using this feature are moved to CLI tests. First, examine the linked code to understand the current implementation. Then, remove the relevant code and check for any dependent tests. Finally, verify that all tests pass.