apache/openwhisk

WskAdminTests test subjects not clean before tests run

Open

#3137 opened on Dec 29, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (6,777 stars) (1,177 forks)batch import
good first issuetesting

Description

The test entitled "block and unblock a user respectively" fails when the namespace testspace containers pre-existing users. This situation can arise if the test was aborted previously without cleaning up the subjects in the namespace. Using the beforeAll method, each namespace used in the suite, testspace, testspace1, testspace2, should be cleared of existing users.

Failure output example:

org.scalatest.exceptions.TestFailedException: "95cc7c53-e0a3-4ec6-8f09-a6d6e10bf4ce:Y1Uhkx1xYFB0ymrXokquAHckNk8ROphVcMiH50YdTEz1Ua6I7kmQJG0hvDGNLtZk
2cbf8758-c9a6-4d56-bf87-58c9a66d5613:nAvoOQB99dlBExF5eY1CjZqIEJY82TtwXFMvr1XO0R2aEfjipK1F3SdJKeIMXlho" did not include substring "92cf9ade-fedd-4dc9-8f9a-defedd3dc946:bis3nKG6ff38v7xQVhZfYO5VHPFZCDeB4T4ERKY7jGsiDuztk2cCOnJafUdrOtc3"
	at org.scalatest.MatchersHelper$.indicateFailure(MatchersHelper.scala:340)
	at org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:6668)
	at org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6704)
	at whisk.core.admin.WskAdminTests$$anonfun$5$$anonfun$apply$3.apply(WskAdminTests.scala:127)
	at whisk.core.admin.WskAdminTests$$anonfun$5$$anonfun$apply$3.apply(WskAdminTests.scala:124)

Line of failure in test suite: https://github.com/apache/incubator-openwhisk/blob/0f679adcf8cf1f29fde8f99c16f66a98e3ec021f/tests/src/test/scala/whisk/core/admin/WskAdminTests.scala#L127

Contributor guide

Tech stack
scala
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ScalaScalaTestOpenWhisk admin tests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue requires modifying the test file WskAdminTests.scala to add a beforeAll method that clears pre existing users from namespaces testspace, testspace1, and testspace2 before the test suite runs. The failing test is at line 127 and involves checking the list of subjects. A common approach is to delete all users in those namespaces before executing tests to ensure a clean state.