apache/openwhisk

Support Default Parameters for Sequences

Open

#2,008 opened on Mar 11, 2017

View on GitHub
 (7 comments) (3 reactions) (0 assignees)Scala (1,177 forks)batch import
controllerhelp wantedsequences

Repository metrics

Stars
 (6,777 stars)
PR merge metrics
 (Avg merge 17h 31m) (3 merged PRs in 30d)

Description

Environment details:

IBM-Bluemix (US-South)

Steps to reproduce the issue:

 wsk action create test --sequence /whisk.system/combinators/trycatch  -p '$tryName' foo -p '$catchName' bar

Provide the expected results and outputs:

Looking at wsk action get test I can see that the parameters passed during the creation are ignored.

Digging into the code, I can see this snippet which looks like the culprit. https://github.com/openwhisk/openwhisk/blob/10c182b26427e61db23a4a829fa5739dd6387c5a/core/controller/src/main/scala/whisk/core/controller/Actions.scala#L354-L362

Additional information you deem important:

Being able to store default parameters for a sequence action provides a convenient way to define new actions from the combinator actions without having to pass in the parameters each time or bind them into a separate package for each instance.

Contributor guide

Research direction
Inspect the code around line 354-362 in Actions.scala to understand how sequence action parameters are processed. Trace the parameter handling to identify where defaults are ignored.
Tech stack
scala
Domain
backendcloud
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitScala
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60