[BUG] SDIO `callbackenable` should only exist if HPWORK queue support is enabled
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- c
- Domain
- operating-systems
Research direction
Start in include/nuttx/sdio.h and inspect the HPWORK queue guards around the SDIO callback-related declarations, including callbackenable. Ensure these declarations are unavailable when HPWORK support is disabled, then verify the header across configurations with and without work queue support.
Written by the indexing model from the issue text.
Description
Description / Steps to reproduce the issue
The callbackenable function prototype exists outside of the ifdef guards for HPWORK queue support in include/nuttx/sdio.h.
However, this function is meant to enable the callback function that was registered earlier based on some events. I don't see why this should exist without the work queue, since without the work queue no callback can even be registered. This means the system is enabling nothing. All callback-related functions should not exist without work queue support.
On which OS does this issue occur?
[OS: Linux]
What is the version of your OS?
Arch Linux
NuttX Version
master
Issue Architecture
[Arch: all]
Issue Area
[Area: Drivers]
Host information
N/A
Verification
- I have verified before submitting the report.
- Dominant language
- C
- Stars
- 4k
- Forks
- 1.7k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 241
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/nuttx
-
Arch: xtensa Area: Drivers OS: Linux Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Arch: all Area: Drivers OS: Linux Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Arch: all OS: Linux Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·