apps/modbus/mb_m.c: missing eMBMasterASCIIStart definition
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- c
- Domain
- embedded-iot, networking
Research direction
Start in apps/modbus/mb_m.c at eMBMasterInit and inspect the MB_ASCII_MASTER branch and its referenced ASCII callbacks. Build with MB_ASCII_MASTER enabled, then verify that the missing ASCII symbols and the unhandled master events no longer produce the reported compiler diagnostics.
Written by the indexing model from the issue text.
Description
(This issue was reported by user @klmchp at incubator-nuttx repository)
Error message as shown below when enabled MB_ASCII_MASTER:
mb_m.c: In function 'eMBMasterInit':
mb_m.c:176:33: error: 'eMBMasterASCIIStart' undeclared (first use in this function); did you mean 'eMBMasterRTUStart'?
176 | pvMBMasterFrameStartCur = eMBMasterASCIIStart;
| ^~~~~~~~~~~~~~~~~~~
| eMBMasterRTUStart
mb_m.c:176:33: note: each undeclared identifier is reported only once for each function it appears in
mb_m.c:177:32: error: 'eMBMasterASCIIStop' undeclared (first use in this function); did you mean 'eMBMasterRTUStop'?
177 | pvMBMasterFrameStopCur = eMBMasterASCIIStop;
| ^~~~~~~~~~~~~~~~~~
| eMBMasterRTUStop
mb_m.c:178:32: error: 'eMBMasterASCIISend' undeclared (first use in this function); did you mean 'eMBMasterRTUSend'?
178 | peMBMasterFrameSendCur = eMBMasterASCIISend;
| ^~~~~~~~~~~~~~~~~~
| eMBMasterRTUSend
mb_m.c:179:35: error: 'eMBMasterASCIIReceive' undeclared (first use in this function); did you mean 'eMBMasterRTUReceive'?
179 | peMBMasterFrameReceiveCur = eMBMasterASCIIReceive;
| ^~~~~~~~~~~~~~~~~~~~~
| eMBMasterRTUReceive
mb_m.c:181:39: error: 'xMBMasterASCIIReceiveFSM' undeclared (first use in this function); did you mean 'xMBMasterRTUReceiveFSM'?
181 | pxMBMasterFrameCBByteReceived = xMBMasterASCIIReceiveFSM;
| ^~~~~~~~~~~~~~~~~~~~~~~~
| xMBMasterRTUReceiveFSM
mb_m.c:182:43: error: 'xMBMasterASCIITransmitFSM' undeclared (first use in this function); did you mean 'xMBMasterRTUTransmitFSM'?
182 | pxMBMasterFrameCBTransmitterEmpty = xMBMasterASCIITransmitFSM;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| xMBMasterRTUTransmitFSM
mb_m.c:183:38: error: 'xMBMasterASCIITimerT1SExpired' undeclared (first use in this function); did you mean 'xMBASCIITimerT1SExpired'?
183 | pxMBMasterPortCBTimerExpired = xMBMasterASCIITimerT1SExpired;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| xMBASCIITimerT1SExpired
mb_m.c:185:17: warning: implicit declaration of function 'eMBMasterASCIIInit'; did you mean 'eMBMasterTCPInit'? [-Wimplicit-function-declaration]
185 | eStatus = eMBMasterASCIIInit(ucPort, ulBaudRate, eParity);
| ^~~~~~~~~~~~~~~~~~
| eMBMasterTCPInit
mb_m.c: In function 'eMBMasterPoll':
mb_m.c:301:7: warning: enumeration value 'EV_MASTER_PROCESS_SUCCESS' not handled in switch [-Wswitch]
301 | switch (eEvent)
| ^~~~~~
mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_RESPOND_TIMEOUT' not handled in switch [-Wswitch]
mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_RECEIVE_DATA' not handled in switch [-Wswitch]
mb_m.c:301:7: warning: enumeration value 'EV_MASTER_ERROR_EXECUTE_FUNCTION' not handled in switch [-Wswitch]
- Dominant language
- C
- Stars
- 465
- Forks
- 782
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 44
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/nuttx-apps
-
Type: Enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/nuttx-apps#3620 · 5 comments · 1 reaction ·
-
Type: Bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
apache/nuttx-apps#3634 · 1 comment ·
-
apache/nuttx-apps#3436 · 1 assignee ·
-
[FEATURE/SECURITY/BUG] Add hash key validation to check the files downloaded from external projects OpenType: Bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/nuttx-apps#3418 ·
-
Type: Bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/nuttx-apps#3407 · 14 comments ·
All issues in apache/nuttx-apps
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·