Clean up Makefile/Kconfig dependency checks
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- build-system
Research direction
Review the listed application Makefiles, their Make.defs entries, and corresponding Kconfig dependencies, starting with the duplicate CONFIG_appname checks. For each application, determine whether the whole-app dependency belongs in Kconfig or whether a Makefile check is only enabling partial functionality. Done means duplicate whole-application checks are removed and required dependencies are handled in Kconfig.
Written by the indexing model from the issue text.
Description
Some of the application Makefiles have configuration checks that overlap dependencies given in Kconfig and Make.defs.
Ideally each check should be done at only one place, and dependencies should be handled by Kconfig.
Note that enabling partial functionality based on config checks in Makefile is fine, but if the whole application depends on some configuration item, that should be a dependency in Kconfig.
Makefiles that have a duplicate check for CONFIG_appname in both Make.defs and Makefile:
- fsutils/ipcfg
- fsutils/mkfatfs
- fsutils/mksmartfs
- fsutils/passwd
- netutils/dhcp6c
- netutils/ping
Makefiles that check for some other config item such as CONFIG_NET_UDP. In most cases the dependency is already in Kconfig and the Makefile check can be removed, in other cases dependency should be added to Kconfig:
- netutils/dhcpc
- netutils/dhcpd
- netutils/discover
- netutils/ftpc
- netutils/ftpd
- netutils/ntpclient
- netutils/smtp
- netutils/telnetc
- netutils/tftpc
- netutils/thttpd
- netutils/webclient
- netutils/webserver
- netutils/xmlrpc
- Dominant language
- C
- Stars
- 465
- Forks
- 782
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 44
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/nuttx-apps
-
Type: Enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/nuttx-apps#3620 · 5 comments · 1 reaction ·
-
Type: Bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
apache/nuttx-apps#3634 · 1 comment ·
-
apache/nuttx-apps#3436 · 1 assignee ·
-
[FEATURE/SECURITY/BUG] Add hash key validation to check the files downloaded from external projects OpenType: Bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/nuttx-apps#3418 ·
-
Type: Bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/nuttx-apps#3407 · 14 comments ·
All issues in apache/nuttx-apps
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·