Commented code in MojoExtension.java

Open Beginner friendly
#12,975 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
78/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
build-system

Research direction

Open MojoExtension.java and inspect the commented-out block in the parameter configuration handling shown in the issue. Determine whether it is obsolete, then remove it if appropriate and verify that the Maven build remains unaffected.

Written by the indexing model from the issue text.

Description

bug
Affected version

HEAD

Bug description

figure out what to do about this, probably delete it

                if (parameterConfiguration != null) {
                    Map<String, String> attributes = new HashMap<>(parameterConfiguration.getAttributes());
                    // if (isEmpty(parameterConfiguration.getAttribute("implementation"))
                    //         && !isEmpty(parameter.getImplementation())) {
                    //     attributes.put("implementation", parameter.getImplementation());
                    // }
                    parameterConfiguration = XmlNode.newInstance(
                            parameter.getName(),
                            parameterConfiguration.getValue(),
                            attributes,
                            parameterConfiguration.getChildren(),
                            parameterConfiguration.getInputLocation());

                    children.add(parameterConfiguration);
                }
            }
Dominant language
Java
Stars
5.4k
Forks
3.1k
Avg merge
20h 29m
Merged PRs (30d)
350

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven

All issues in apache/maven

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.