New select-jdk-toolchain goal should warn about empty config

Open Beginner friendly
#183 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
build-system

Research direction

Start with the referenced ToolchainMojo.java warning and locate the implementation of the new select-jdk-toolchain goal. Compare how each goal handles an empty configuration, then determine whether the fix should only warn or also consider the suggested legacy-configuration fallback. Done means the silent exit is addressed consistently with the issue’s intended behavior.

Written by the indexing model from the issue text.

Description

bug
Affected version

3.2.0

Bug description

Old toolchain goal was warning about empty config: ToolchainMojo.java:77:

getLog().warn("No toolchains requirements configured.");

Maybe the new goal should do something similar. Right now it just silently exits.
Found it after mixing old goal configuration with the new select- goal.

Maybe it could be beneficial to parse old configuration in the new goal as a fallback?

Dominant language
Java
Stars
27
Forks
31
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-toolchains-plugin

All issues in apache/maven-toolchains-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.