decrypt() error message omits context from SecDispatcherException

Open Beginner friendly
#153 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
build-system, tooling

Research direction

Start with decrypt() in src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:560-567 and trace the SecDispatcherException message and cause handling. Check the resulting Maven plugin error output for preserved decryption context; the work is done when the reported error retains the relevant root-cause details without losing the exception chain.

Written by the indexing model from the issue text.

Description

bug priority:minor

Affected version: HEAD

File: src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:560-567

The decrypt() method logs the error and re-throws, but the root cause details from SecDispatcherException may be partially lost:

protected String decrypt(String encoded) throws MojoExecutionException {
    try {
        return securityDispatcher.decrypt(encoded);
    } catch (SecDispatcherException e) {
        getLog().error("error using security dispatcher: " + e.getMessage(), e);
        throw new MojoExecutionException("error using security dispatcher: " + e.getMessage(), e);
    }
}

The exception is passed as the cause to MojoExecutionException, so details are preserved in the chain. However, the error message string uses e.getMessage() which may omit important context (like the password key that failed to decrypt). Consider including more context in the message.

Dominant language
Java
Stars
23
Forks
18
Avg merge
4d 16h
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-jarsigner-plugin

All issues in apache/maven-jarsigner-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.