Logging: destination path missing when destination equals basedir in DefaultMavenResourcesFiltering

Open Beginner friendly
#337 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java
Domain
build-system

Research direction

Start in DefaultMavenResourcesFiltering.filterResources(), where the copy-operation log uses basedir.relativize(destination). Reproduce or inspect the case where destination equals basedir, then verify that the completed log message identifies the destination as specified by the issue.

Written by the indexing model from the issue text.

Description

bug
Affected version

3.x

Bug description

When DefaultMavenResourcesFiltering.filterResources() logs copy operations it uses Path.relativize against the project's base directory. If the destination path equals basedir (i.e. copy to the basedir directory), basedir.relativize(destination) returns an empty string, so the log message ends with "to ".
For example: "Copying 1 resource from sourcedir to ".

Current code:

LOGGER.info("Copying " + includedFiles.size() + " resource" + (includedFiles.size() > 1 ? "s" : "")
                        + " from "
                        + basedir.relativize(resourceDirectory.toAbsolutePath())
                        + " to "
                        + basedir.relativize(destination));

The log message should show the destination path:

  • "." or
  • the absolute path or
  • "basedir" / "project base directory"

Suggested code change:

LOGGER.info("Copying " + includedFiles.size() + " resource" + (includedFiles.size() > 1 ? "s" : "")
                        + " from "
                        + basedir.relativize(resourceDirectory.toAbsolutePath())
                        + " to "
                        + (basedir.equals(destination) ? "." : basedir.relativize(destination)));
Dominant language
Java
Stars
9
Forks
36
Avg merge
6h 44m
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-filtering

All issues in apache/maven-filtering

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.