NullPointerException in AbstractEarMojo.isArtifactRegistered() when module artifact is null

Open Beginner friendly
#519 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
90/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
java
Domain
build-system

Research direction

Open AbstractEarMojo.java around line 317 and inspect isArtifactRegistered(), starting with the documented null behavior of EarModule.getArtifact(). Confirm the change prevents an unresolved module from causing a NullPointerException, then run the relevant Maven tests if available and verify resolved artifacts are still checked.

Written by the indexing model from the issue text.

Description

bug

Description

In AbstractEarMojo.java:317, isArtifactRegistered() can throw a NullPointerException:

return currentList.stream().anyMatch(em -> em.getArtifact().equals(a));

EarModule.getArtifact() is documented as returning null until the artifact is resolved. If a module in currentList has not been resolved, .getArtifact() returns null and null.equals(a) throws an NPE.

Expected behavior

Add a null guard:

return currentList.stream().anyMatch(em -> em.getArtifact() != null && em.getArtifact().equals(a));
Dominant language
Java
Stars
14
Forks
29
Avg merge
1d 4h
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/maven-ear-plugin

All issues in apache/maven-ear-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.