[Bug] health_check.bat creates a stray empty directory (e.g. C:\Program) when the install path contains a space
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- shell
- Domain
- operating-systems, tooling
Research direction
Start in scripts/tools/windows/ops/health_check.bat, focusing on the :local_dirs_check routine and its directory iteration. Reproduce with IoTDB installed under a path containing spaces, then verify that tools\windows\ops\health_check.bat -o local reports each configured directory as one path and creates no stray directory.
Written by the indexing model from the issue text.
Description
Search before asking
- I searched in the issues and found nothing similar.
Version
Reproduced on 2.0.8 and current master (identical code). Present since the tool was introduced (#12325); not addressed by #12435 (launch scripts) or #12450 (permission-detection logic).
Environment:
- OS: Windows (reproduces wherever the install path contains a space)
- IoTDB: 2.0.8 and master
Describe the bug and provide the minimal reproduce step
On Windows, if IoTDB is located under a path that contains a space (e.g. C:\Program Files\iotdb), the health-check tool's Installation Environment(Directory Access) check splits directory paths at the space. It:
- creates a stray empty directory such as
C:\Program, and - prints garbled results - e.g.
"C:\Program" has write permissionfollowed by"Files\...\ext\pipe" has write permission- instead of one line for the real directory.
To reproduce:
- Unzip/install IoTDB into a path containing a space, e.g.
C:\Program Files\iotdb(orC:\test dir\iotdb). - Run
tools\windows\ops\health_check.bat -o local. - Observe a stray empty
C:\Programdirectory, and split/garbled lines in the Directory Access section.
Any configured directory under the spaced install path triggers it; the ext/* dirs (pipe_lib_dir / udf_lib_dir / trigger_lib_dir) hit it by default because they resolve to %IOTDB_HOME%\ext\....
Affected file: scripts/tools/windows/ops/health_check.bat, routine :local_dirs_check.
Root cause:
:local_dirs_check joins the directory variables into spacedirs with spaces and iterates with for %%a in (%spacedirs%). The for ... in (set) form tokenizes on spaces (and ,/;), so a path containing a space is split into two
tokens. The inner for %%b/%%c loops already preserve spaces for the ;/, multi-dir separators via the "!var:;=" "!" technique, but the outer space-join defeats that. Separately, %%c (from for %%c in ("...")) still carries its
surrounding quotes, so mkdir "%%c" expands to mkdir ""C:\Program Files\..."" - a doubly-quoted path the argument parser re-splits.
What did you expect to see?
Each configured directory is checked as a single path; no stray directory is created; the output has one clean line per directory.
What did you see instead?
The tool splits directory paths at the space and creates a stray directory.
Anything else?
The docs recommend a space-free install path, but the tool shouldn't create stray directories or emit corrupt output when that guidance isn't met - especially since Windows users frequently install under C:\Program Files. A minimal fix is
available (see PR).
Are you willing to submit a PR?
- I'm willing to submit a PR!
- Dominant language
- Java
- Stars
- 6.4k
- Forks
- 1.2k
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 129
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/iotdb
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
IoTDB Edge: stop-edge.sh does not stop its own process when IOTDB_HOME is set, and reports success Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
[Bug] findColumn throws NullPointerException instead of SQLException for an unknown column name Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Two open-case totals on one screen: the Programs tile says 15,858 and the nav badge says 15,868 Openbug frontend maui-pilot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
objectionary/eo-graphs#74 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100