Why doesn’t SessionDataSet implement the IAsyncDisposable interface?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Locate SessionDataSet and inspect its existing IDisposable implementation, especially Dispose() and the asynchronous Close() entry point. Confirm the class supports asynchronous disposal and that Close() is awaited without changing the existing synchronous disposal behavior; the issue provides no test or file path, so completion should be checked against both disposal paths.
Written by the indexing model from the issue text.
Description
Currently, SessionDataSet implements the IDisposable interface. However, in its Dispose() method, the asynchronous Close() method is invoked synchronously.
Actual implementation:
protected virtual void Dispose(bool disposing)
{
if (this.disposedValue)
return;
if (disposing)
{
try
{
//synchronous call
this.Close().Wait();
}
catch
{
}
}
this.disposedValue = true;
}
Proposed implementation:
protected virtual Task DisposeAsync(bool disposing)
{
if (this.disposedValue)
return;
if (disposing)
{
try
{
//asynchronous call
await this.Close();
}
catch
{
}
}
this.disposedValue = true;
}
- Dominant language
- C#
- Stars
- 24
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/iotdb-client-csharp
-
网络波动后导致获取连接失败 Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
apache/iotdb-client-csharp#58 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
apache/iotdb-client-csharp#55 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
apache/iotdb-client-csharp#53 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
apache/iotdb-client-csharp#50 · 5 comments · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/iotdb-client-csharp#36 · 1 comment · 1 reaction ·
All issues in apache/iotdb-client-csharp
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Altinn/altinn-auth#4143 ·