Existing params can be dropped when code param is added

Open
#10 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Quiet
Tech stack
python
Domain
api, authentication

Research direction

Locate the code that builds the query-parameter dict and reproduce the case where an incoming code parameter is present before the OAuth code is added. Review issue #9 and decide which documented behavior this issue should follow; done means existing parameters are no longer silently lost and the chosen behavior is covered by a test.

Written by the indexing model from the issue text.

Description

bug

The existing code uses a dict to hold query params, which means that adding a code param will replace any existing code param.

This is not documented.

Possible approaches are:

  • don't allow a code parameter; throw an error if found
  • allow an incoming code parameter, and return the Oauth code appended to the query string. It would be the responsibility of the caller to manage the extraction of the appropriate code entry.

See also #9 which aims to fix the loss of duplicate parameter names.

Dominant language
Python
Stars
13
Forks
27
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/infrastructure-oauth

All issues in apache/infrastructure-oauth

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.