apache/gravitino

[Improvement] Possible null pointer exception in CatalogRegister.java

Open

#4,189 opened on Jul 18, 2024

View on GitHub
 (14 comments) (0 reactions) (1 assignee)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be improved?

In checkCatalogExist, failedException is set to null and then thrown which could cause a NPE if it is not set in the exception block.

How should we improve?

Move throw failedException; to the correct place in the catch block?

Contributor guide

Research direction
Inspect CatalogRegister.java's checkCatalogExist method and move the throw failedException inside the catch block to prevent potential NPE.
Tech stack
java
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75