apache/dubbo

[CodeReview 3.0] Dubbo in spring

Open

#8,633 opened on Aug 29, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (26,453 forks)batch import
help wanted

Repository metrics

Stars
 (41,524 stars)
PR merge metrics
 (Avg merge 7d 14h) (20 merged PRs in 30d)

Description

1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.

DubboConfigConfigurationRegistrar only has one function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);
}

but DubboComponentScanRegistrar also has this function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);

    Set<String> packagesToScan = getPackagesToScan(importingClassMetadata);

    registerServiceAnnotationPostProcessor(packagesToScan, registry);
}

Contributor guide