apache/dubbo

System environment variable naming（dubbo.application.logger）

Open

#7,013 opened on Dec 10, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (26,453 forks)batch import
help wantedtype/proposal

Repository metrics

Stars
 (41,524 stars)
PR merge metrics
 (Avg merge 7d 14h) (20 merged PRs in 30d)

Description

org.apache.dubbo.common.logger.LoggerFactory.java:44

这个类里面，根据系统环境变量的配置，创建指定类型的LoggerAdapter 这里面使用的环境变量的名称，没考虑过不同系统的支持吗？

dubbo.application.logger

这种命名风格的系统环境变量，在类linux下是无法创建成功的，在Windows下是可以的。

建议官方考虑一下使用场景，既然是系统环境变量，就得考虑不同类型系统是否支持。

虽然通过-Ddubbo.application.logger=log4j,在通过java指令执行期也是可以解的，但如果是配置系统环境变量，linux下不好解

Contributor guide

Research direction
Investigate how to support environment variable names with dots across different operating systems. Consider using underscores or normalizing the variable name before lookup.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Javaenvironment variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65