apache/dubbo

JVMUtil performance improvement

Open

#13,327 opened on Nov 7, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (26,453 forks)batch import
component/sdkhelp wantedtype/enhancement

Repository metrics

Stars
 (41,524 stars)
PR merge metrics
 (Avg merge 7d 14h) (20 merged PRs in 30d)

Description

https://github.com/apache/dubbo/blob/3.0/dubbo-common/src/main/java/org/apache/dubbo/common/utils/JVMUtil.java

JVMUtil. jstack方法调用整体使用OutputStream作为输出可提升性能，而内部JVMUtil.getThreadDumpString使用String长字符串拼接反而降低了性能。 建议修改内部JVMUtil.getThreadDumpString方法同样为流式处理，减少字符串拼接的性能开销

同时，getThreadDumpString方法内部，可能还考虑性能影响，增加了栈深度控制（默认32）。 这个深度控制、对性能的提升，可能没有流式处理改造能带来的性能提升高。建议应先修改流式处理以提升性能。是否可经测试评估性能影响，取消栈深度控制。以便dubbo的threaddump能够使用在各类Thread分析工具中（如flamegraph.pl等）。

Contributor guide

Research direction
Change the internal getThreadDumpString method to use OutputStream for streaming output instead of String concatenation. Evaluate whether the stack depth control (default 32) provides enough performance benefit to keep, or if it can be removed after switching to streaming.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaStream API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70