apache/dubbo

TimeCounterEvent optimization

Open

#13,097 opened on Sep 21, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (26,453 forks)batch import
component/sdkhelp wantedtype/proposal

Repository metrics

Stars
 (41,524 stars)
PR merge metrics
 (Avg merge 7d 14h) (20 merged PRs in 30d)

Description

TimeCounterEvent in the Metrics module is now an abstract class, and events inherit from it to have the ability to calculate rt. Inheritance mechanism brings inflexibility and sometimes we have to inherit it in event generics. We can use composition pattern instead of inheritance

Contributor guide

Research direction
Replace inheritance of TimeCounterEvent with composition by creating a separate class for rt calculation and injecting it into events.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70