apache/dubbo

ZookeeperRegistryNotifier 无法实现多次通知合并的功能？

Open

#11,257 opened on Jan 9, 2023

View on GitHub
 (8 comments) (0 reactions) (1 assignee)Java (26,453 forks)batch import
help wantedtype/bug

Repository metrics

Stars
 (41,524 stars)
PR merge metrics
 (Avg merge 7d 14h) (20 merged PRs in 30d)

Description

不太理解 ZookeeperRegistryNotifier 的 notify() 方法里面，为什么要进行 sleep ？

我一开始以为是这里说的【延迟通知】https://cn.dubbo.apache.org/zh/blog/2022/06/23/%e6%b5%85%e6%9e%90-dubbo-3.0-%e4%b8%ad%e6%8e%a5%e5%8f%a3%e7%ba%a7%e5%9c%b0%e5%9d%80%e6%8e%a8%e9%80%81%e6%80%a7%e8%83%bd%e7%9a%84%e4%bc%98%e5%8c%96/#%E5%BB%B6%E8%BF%9F%E9%80%9A%E7%9F%A5

但是阅读代码之后，发现应该起不到这里说的【延迟通知】的效果。

看了 org.apache.dubbo.registry.RegistryNotifier#notify 的实现，org.apache.dubbo.registry.zookeeper.ZookeeperRegistry.ZookeeperRegistryNotifier#notify 的实现的确有问题，ZookeeperRegistryNotifier实现不了【阻塞期间，多次通知的合并】

Contributor guide

Research direction
Compare the notify method in ZookeeperRegistryNotifier with the base class RegistryNotifier to understand the intended merge behavior and identify the bug.
Tech stack
java
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaApache Dubbo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50