apache/dolphinscheduler

[Feature][python] Remove public call in PythonGateway code

Open

#10,990 opened on Jul 15, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,324 forks)batch import
Pyschedulerfeaturehelp wanted

Repository metrics

Stars
 (11,659 stars)
PR merge metrics
 (Avg merge 2d 21h) (22 merged PRs in 30d)

Description

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

after #10989 finishes, all functions in PythonGateway just look like https://github.com/apache/dolphinscheduler/blob/7196b125d9a6612f2f175c2190d7758a09d7e0b9/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java#L394-L396 and maybe we can find some way not declaire the function in PythonGateway, and directly import this function from python api side, we currently have some simple code in https://github.com/apache/dolphinscheduler/blob/5289b09817396046489b28857ad54a85c5ffddb2/dolphinscheduler-python/pydolphinscheduler/tests/integration/test_java_gateway.py#L40-L53

and maybe we can do some things like that, and maybe at last our PythonGateway will only have https://github.com/apache/dolphinscheduler/blob/7196b125d9a6612f2f175c2190d7758a09d7e0b9/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java#L566-L594 content

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide