apache/dolphinscheduler

[Feature][Python] Migrate all exists method call in PythonGateway to corresponding service

Open

#10,989 opened on Jul 15, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,324 forks)batch import
Pyschedulerfeaturehelp wanted

Repository metrics

Stars
 (11,659 stars)
PR merge metrics
 (Avg merge 2d 21h) (22 merged PRs in 30d)

Description

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

In https://github.com/apache/dolphinscheduler/blob/1fcbbb653440106fc5ca94a6a9e2d218dc3be97f/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java, we will export function to make them available to in python API, but we have to handle many Java map or result object situation. I think we should migrate them into corresponding service instead of PythonGateway, and keep PythonGateway in simple call like what I do in https://github.com/apache/dolphinscheduler/blob/7196b125d9a6612f2f175c2190d7758a09d7e0b9/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java#L363-L375

And after that, we only need to one line call in PythonGateway, such as https://github.com/apache/dolphinscheduler/blob/7196b125d9a6612f2f175c2190d7758a09d7e0b9/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/python/PythonGateway.java#L394-L396

It makes our code clean, besides, we should do some refactoring in corresponding service when you migrate python gateway service. such as #10792 we will refactor the QueueServiceImpl.java and TenantService.java code

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Research direction
Investigate the PythonGateway.java file and the referenced service implementations (e.g., TenantServiceImpl, QueueServiceImpl) to understand the pattern of calling service methods. Then, for each method in PythonGateway that uses 'map' or 'result' objects, refactor the corresponding service to expose a simpler method, and update the PythonGateway to call it in one line.
Tech stack
java
Domain
backendapidata
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70