Add proper module name in Manifest

Open Beginner friendly
#731 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
build-system

Research direction

Start with the Maven build configuration that creates the library JAR and compare its generated manifest with the example in the issue. Add the requested Automatic-Module-Name entry through the jar manifest configuration, then verify that the built manifest contains org.apache.datasketches.

Written by the indexing model from the issue text.

Description

Hello,

Any plan to add proper jpms/JDK9 module configuration into the library?

Current manifest looks like :

Manifest-Version: 1.0
Build-Jdk-Spec: 25
Build-OS: Mac OS X aarch64 26.1
Build-Tool-Jdk-Spec: 25
GroupId-ArtifactId: org.apache.datasketches:datasketches-java
Implementation-Vendor: The Apache Software Foundation
git-branch: 9.0.X
git-commit-id: f3b334b380feee9f928500de9adb6bbf763fc104
git-commit-tag: 9.0.0-RC1
git-commit-time: 
git-commit-user-email: xxx@yyy.com

An easy way forward would be through an additional Automatic-Module-Name entry, like:

Automatic-Module-Name: org.apache.datasketches

it can be done with something like:

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-jar-plugin</artifactId>
	<configuration>
		<archive>
			<manifestEntries>
				<Automatic-Module-Name>org.apache.datasketches</Automatic-Module-Name>
			</manifestEntries>
		</archive>
	</configuration>
</plugin>

edit: I would benefit from this going from datasketches 7.X

Dominant language
Java
Stars
958
Forks
226
Avg merge
3d 40m
Merged PRs (30d)
13

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/datasketches-java

All issues in apache/datasketches-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.