Add proper module name in Manifest
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- java
- Domain
- build-system
Research direction
Start with the Maven build configuration that creates the library JAR and compare its generated manifest with the example in the issue. Add the requested Automatic-Module-Name entry through the jar manifest configuration, then verify that the built manifest contains org.apache.datasketches.
Written by the indexing model from the issue text.
Description
Hello,
Any plan to add proper jpms/JDK9 module configuration into the library?
Current manifest looks like :
Manifest-Version: 1.0
Build-Jdk-Spec: 25
Build-OS: Mac OS X aarch64 26.1
Build-Tool-Jdk-Spec: 25
GroupId-ArtifactId: org.apache.datasketches:datasketches-java
Implementation-Vendor: The Apache Software Foundation
git-branch: 9.0.X
git-commit-id: f3b334b380feee9f928500de9adb6bbf763fc104
git-commit-tag: 9.0.0-RC1
git-commit-time:
git-commit-user-email: xxx@yyy.com
An easy way forward would be through an additional Automatic-Module-Name entry, like:
Automatic-Module-Name: org.apache.datasketches
it can be done with something like:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>org.apache.datasketches</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin>
edit: I would benefit from this going from datasketches 7.X
- Dominant language
- Java
- Stars
- 958
- Forks
- 226
- Avg merge
- 3d 40m
- Merged PRs (30d)
- 13
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/datasketches-java
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
apache/datasketches-java#739 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/datasketches-java#720 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
apache/datasketches-java#693 · 13 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
apache/datasketches-java#647 · 5 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/datasketches-java#569 ·
All issues in apache/datasketches-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100