Reorganization proposal
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- build-system
Research direction
Review the repository's existing component folders and their include/ directories, then compare them with the proposed include/datasketches layout and the pybind11 precedent linked in the issue. Before changing files, confirm that maintainers have agreed on a target organization; done would require an accepted layout that provides a single include path for foreign build systems.
Written by the indexing model from the issue text.
Description
Hi there,
We are consider using datasketches in our C++ environment. The current organization, where there a bunch of folders, each with an include/ directory, is a bit awkward for integrating into a foreign build system. Projects like pybind11 put all of the headers in a single include/ directory (perhaps with subdirectories underneath). Then there is just a single path to add as an include path.
Would you be open to a reorganization that moved around files to look a bit like this:
include/datasketches
count/
count_min.hpp
count_min_impl.hpp
common/
MurmurHash3.h
...
Thanks for your consideration.
- Dominant language
- C++
- Stars
- 273
- Forks
- 88
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/datasketches-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
apache/datasketches-cpp#499 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
apache/datasketches-cpp#502 · 11 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
apache/datasketches-cpp#460 · 6 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
apache/datasketches-cpp#457 · 8 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/datasketches-cpp#416 · 13 comments ·
All issues in apache/datasketches-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·