Fix licensing issues in source release found during 0.63.0 RC1 vote (missing NOTICE file, flamegraph.svg with CDDL-licensed JavaScript)

Open Beginner friendly
#2,495 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
release

Research direction

Start at the repository root with the 0.63.0-rc1 source archive and inspect NOTICE, LICENSE.TXT, and sqlparser_bench/img/flamegraph.svg; run the issue's ls and grep checks to confirm the findings. Done means the source release includes the required NOTICE file and excludes the generated flamegraph.svg without retaining the CDDL-licensed JavaScript.

Written by the indexing model from the issue text.

Description

Describe the bug

During the vote on the Apache DataFusion sqlparser-rs 0.63.0 RC1 release, @Xuanwo identified two licensing-material issues in the source archive and voted -1 (non-binding): https://lists.apache.org/thread/3lnhgs0bwzl148yrdrcl5g005h9pgtmx

  1. Missing NOTICE file: the source archive contains LICENSE.TXT but no NOTICE file, which ASF releases are expected to include.
  2. sqlparser_bench/img/flamegraph.svg embeds third-party licensed code: the generated flamegraph embeds JavaScript from Inferno, whose upstream license is CDDL 1.0, but the archive contains no corresponding license materials.

To Reproduce

Download and unpack the 0.63.0 RC1 source archive (or check the repository at v0.63.0-rc1):

$ ls NOTICE*
ls: NOTICE*: No such file or directory

$ grep -c -i inferno sqlparser_bench/img/flamegraph.svg
2

Expected behavior

The source release complies with ASF licensing policy:

  1. Add a NOTICE file to the repository so it is included in source archives.
  2. Exclude the generated sqlparser_bench/img/flamegraph.svg from the source release

Additional context

Dominant language
Rust
Stars
3.5k
Forks
774
Avg merge
3d 10h
Merged PRs (30d)
15

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/datafusion-sqlparser-rs

All issues in apache/datafusion-sqlparser-rs

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.