Allow comma in buildSettings

Open

#86 opened on Feb 17, 2020 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: ios, javascript, nodejs
Domain: build-system, mobile

Research direction

Start with the pbxproj.js parser referenced in the error and trace how buildSettingsObj.TARGETED_DEVICE_FAMILY is parsed or serialized. Reproduce the failure with the value '1,2', then verify that the Xcode project value is accepted without the reported comma syntax error.

Written by the indexing model from the issue text.

Description

when i try to set "TARGETED_DEVICE_FAMILY", it failed.
buildSettingsObj.TARGETED_DEVICE_FAMILY = '1,2'

While preparing Cordova project for platform iOS:
   SyntaxError: Expected ".", "/*", ";", or [0-9] but "," found.
   at peg$buildStructuredError (/Users/monsterstep/.meteor/packages/meteor-tool/.1.9.0.1eehdch.kfff++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/cordova-lib/node_modules/xcode/lib/parser/pbxproj.js:412:12)
   at Object.peg$parse [as parse] (/Users/monsterstep/.meteor/packages/meteor-tool/.1.9.0.1eehdch.kfff++os.osx.x86_64+web.browser+web.browser.legacy+web.cordova/mt-os.osx.x86_64/dev_bundle/lib/node_modules/cordova-lib/node_modules/xcode/lib/parser/pbxproj.js:1886:11)

the xcodeproj has value like this

https://github.com/apache/cordova-node-xcode/issues/57

Dominant language: JavaScript
Stars: 217
Forks: 102
Avg merge: 2d 9h
Merged PRs (30d): 8

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

P4 FR: Add one-click copy-to-clipboard button to code snippets in static workshop HTML Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

palladius/rails8-app-on-gcp#145 · Opened Sep 23, 2026
Disable auto-cloaking not working Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

dotenvx/dotenv-vscode#139 · Opened Sep 23, 2026
Remove sw.https.window.html and sw-416.https.window.html from Interop 2026 fetch Open

test-change-proposal

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

web-platform-tests/interop#1455 · Opened Sep 23, 2026
Missing security headers on corsair.dev (CSP, X-Frame-Options, etc.) Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

corsairdev/corsair#1764 · Opened Sep 23, 2026
Empty .ts route file is scaffolded with JSX, breaking all route generation Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

TanStack/router#8480 · Opened Sep 23, 2026

More JavaScript issues