Allow asterisks in comments
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, nodejs
- Domain
- tooling
Research direction
Locate the parser entry point that handles /* comments and reproduce the failure with /* Upload *.dSYM to Firebase */. Trace how the comment body is scanned, then verify that an internal asterisk is accepted while the closing */ still terminates the comment without a SyntaxError.
Written by the indexing model from the issue text.
Description
Once the parser passes a /* token, it proceeds to search for a */ token, throwing a SyntaxError as soon as it encounter an asterisk not immediately followed by a slash. Comments can contain asterisks though. Many of these comments in project files are autogenerated, for example based on a file name which could have an asterisk in it.
Could the parser ignore * characters between /* and */, continuing its search without issue until it finds the closing */?
To reproduce the below, call the parser on any (file containing a) line such as /* Upload *.dSYM to Firebase */:
Thrown:
{ [SyntaxError: Expected "*/" or [^*] but "*" found.
]
message: 'Expected "*/" or [^*] but "*" found.',
expected:
[ { type: 'class',
parts: [Array],
inverted: true,
ignoreCase: false },
{ type: 'literal', text: '*/', ignoreCase: false },
{ type: 'class',
parts: [Array],
inverted: true,
ignoreCase: false },
{ type: 'literal', text: '*/', ignoreCase: false } ],
found: '*',
location:
{ start: { offset: 697, line: 13, column: 35 },
end: { offset: 698, line: 13, column: 36 } },
name: 'SyntaxError' }
- Dominant language
- JavaScript
- Stars
- 217
- Forks
- 102
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/cordova-node-xcode
-
Add & Improve JSDocs Openenhancement
apache/cordova-node-xcode#171 · 1 assignee ·
-
🔖 New release Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/cordova-node-xcode#162 · 4 comments · 2 reactions ·
-
Install .xcframework Open
Difficulty 3/5 1-2 days Newbie friendliness 28/100
apache/cordova-node-xcode#139 · 2 comments ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/cordova-node-xcode#138 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/cordova-node-xcode#137 · 2 reactions ·
All issues in apache/cordova-node-xcode
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
docToolchain/docToolchain#1705 ·
-
Timezone select lists one option per character; duplicate "Failed" reason; shared tracker popover id Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1414 ·
-
bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/inspector#2458 · 1 comment ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
carbon-design-system/ibm-products#9907 ·