addBuildPhase keeps adding phases when they already exist
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- ios, javascript, node.js
- Domain
- cli, mobile-dev
Research direction
Start by locating the addBuildPhase call shown in the build script and inspect how it handles existing phases named "Configure Crashlytics". Re-run the CLI build against an Xcode project more than once; done means repeated runs leave one such build phase and still write the project successfully.
Written by the indexing model from the issue text.
Description
This is the build script line
xcodeProject.addBuildPhase(
[], 'PBXShellScriptBuildPhase', 'Configure Crashlytics', undefined, options
).buildPhase;
fs.writeFileSync(xcodeProjectPath, xcodeProject.writeSync());
$logger.trace('Xcode project written');
} else {
$logger.error(xcodeProjectPath + ' is missing.');
reject();
return;
}
So I guess everytime the CLI build runs it adds a NEW "Configure Crashlytics" to the build phase. Eventually my machine just outright died because the script was running hundreds of times.
Is there maybe a way before this I can check to see if it exists first before just adding it again?
- Dominant language
- JavaScript
- Stars
- 217
- Forks
- 102
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/cordova-node-xcode
-
Add & Improve JSDocs Openenhancement
apache/cordova-node-xcode#171 · 1 assignee ·
-
🔖 New release Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
apache/cordova-node-xcode#162 · 4 comments · 2 reactions ·
-
Install .xcframework Open
Difficulty 3/5 1-2 days Newbie friendliness 28/100
apache/cordova-node-xcode#139 · 2 comments ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
apache/cordova-node-xcode#138 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/cordova-node-xcode#137 · 2 reactions ·
All issues in apache/cordova-node-xcode
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
palladius/rails8-app-on-gcp#145 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
web-platform-tests/interop#1455 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100