apache/brpc

Remove implementation specific function name of EventDispatcher

Open

#1,894 opened on Aug 17, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (16,226 stars) (3,936 forks)batch import
good first issuerefactor

Description

Some of the member functions of EventDispatcher are implementation specific, for example AddEpollOut.

We need to change that specific function name and adopt more general name then we can easily support brpc to more platforms.

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ programmingEventDispatcher component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the EventDispatcher class in the source code, likely in `src/brpc/event dispatcher.cpp`. Identify all occurrences of the function `AddEpollOut` and understand its platform specific context. Propose a generic name such as `AddPollableFd` or `AddEvent`, then rename the function and update all references. Check the issue comments for any prior discussion on naming conventions or preferred alternatives.
Remove implementation specific function name of EventDispatcher · apache/brpc#1894 | Good First Issue