apache/beam

[Bug][Go]: Metrics incremented in Setup methods are not recalled.

Open

#27,038 opened on Jun 6, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (7,313 stars) (4,097 forks)batch import
P3buggogood first issue

Description

What happened?

Because the ParDo Setup context is uncached metrics initialized in Setup are lost, which is unexpected. Work done in setup, while logically outside of a bundle, will be under the context of the first bundle to execute that transform.

So there needs to be a way to transfer/extract the metrics from the Setup context so they are recorded back to the runner.

Issue Priority

Priority: 3 (minor)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner

Contributor guide

Tech stack
go
Domain
data
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingApache Beam basicsmetrics concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the uncached Setup context in pardo.go (line 104). Understand how metrics are currently lost and propose a mechanism to extract/transfer them from the Setup context to be recorded back to the runner. Consider caching the Setup context or piping metrics differently.
[Bug][Go]: Metrics incremented in Setup methods are not recalled. · apache/beam#27038 | Good First Issue