apache/beam

Migrate common_job_properties.groovy to use Maps for keyword argument style calls instead of positional arguments

Open

#18,768 opened on Jun 3, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (4,097 forks)batch import
P3good first issueimprovementtests

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (Avg merge 6d) (243 merged PRs in 30d)

Description

This follows the the style defined within build_rules.gradle as it is much simpler to read the following method with keyword arguments: setCommonJobProperties(context: context, maxWorkers: 3)

This also simplifies the usage of methods with multiple default arguments.

Imported from Jira BEAM-4235. Original Jira may contain additional context. Reported by: lcwik.

Contributor guide

Research direction
Examine the style used in build rules.gradle around line 397, then apply keyword argument style to common job properties.groovy by converting positional arguments to map based calls.
Tech stack
groovy
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GroovyGradle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60