apache/beam

WindowFnTestUtils#runWindowFn should be removed

Open

#18,458 opened on Jun 3, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Java (4,097 forks)batch import
P3bugcoregood first issuejava

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (PR metrics pending)

Description

Its use makes test methods (like most SlidingWIndow tests) very difficult to read, as there's no obvious behavior that is being tested for.

Imported from Jira BEAM-2525. Original Jira may contain additional context. Reported by: tgroh.

Contributor guide

Research direction
Remove the method WindowFnTestUtils.runWindowFn and replace all its usages with direct test assertions that verify the expected window behavior. Look for all callers in the codebase and update them accordingly.
Tech stack
java
Domain
data
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70