apache/beam

TextIOReadTest creates pipelines with non-unique application names

Open

#18,398 opened on Jun 3, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (4,097 forks)batch import
P4bugcoregood first issuejava

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (Avg merge 6d) (243 merged PRs in 30d)

Description

The test TextIOReadTest uses a loop to create a few tests within a single test method. This results in a pipeline with non-unique applied transform nodes.

Perhaps the best way to fix this is to use a JUnit Paramaterized test suite, or multiple. It does seem that the test is basically doing the full product of empty/tiny/large with various compression types.

Imported from Jira BEAM-2632. Original Jira may contain additional context. Reported by: kenn.

Contributor guide

Research direction
Refactor TextIOReadTest to use JUnit Parameterized test suite to ensure unique pipeline application names and avoid duplication.
Tech stack
java
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70