apache/beam

Refactor PTransformOverrideFactories to remove code duplication

Open

#18,373 opened on Jun 3, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (4,097 forks)batch import
P3bugcoregood first issuerunners

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (Avg merge 6d) (243 merged PRs in 30d)

Description

The majority of the factories take in a single PCollection as input and produce a single PCollection as output; the code to extract the single input can be invisible as part of the class hierarchy, rather than explicitly called in every override.

Imported from Jira BEAM-1982. Original Jira may contain additional context. Reported by: tgroh.

Contributor guide

Research direction
Examine the PTransformOverrideFactories to identify common patterns. Propose a base class or abstract method to encapsulate the single input extraction, reducing duplicate code in each override.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaApache Beam
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25