apache/beam

Add TriggerTester methods to check that timers are set

Open

#18084 opened on Jun 3, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (7,313 stars) (4,097 forks)batch import
P3bugcoregood first issuerunnerstests

Description

TriggerTester exposes a fireIfShouldFire(BoundedWIndow) method. This is used to prompt a call to the trigger with the current state of the trigger tester (Input Watermarks, elements present, etc), and see if the trigger should fire. This is sufficient to test shouldFire of the TriggerStateMachine under test, but does not test that the onElement method sets an appropriate timer to cause such an interrogation to occur.

Imported from Jira BEAM-694. Original Jira may contain additional context. Reported by: jkff.

Contributor guide

Tech stack
java
Domain
testingbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Beam triggersJava proficiency
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the TriggerTester class, particularly the fireIfShouldFire method. Understand how the trigger state machine works to determine what timer setting methods need to be added. Look for any existing tests related to timers in the Beam codebase. The original Jira issue (BEAM 694) may contain additional context that clarifies the expected behavior.