apache/beam

StateTags$CombiningValueStateTag inherits equals from super class but without incorporating its state

Open

#18,017 opened on Jun 3, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (4,097 forks)batch import
P3bugcoregood first issuejava

Repository metrics

Stars
 (7,313 stars)
PR merge metrics
 (Avg merge 6d) (243 merged PRs in 30d)

Description

FindBugs EQ_DOESNT_OVERRIDE_EQUALS: Class doesn't override equals in superclass

Applies to: StateTags$CombiningValueStateTag. CombiningValueStateTag inherits its equals implementation from its parent class, KeyedCombiningValueStateTag. CombiningValueStateTag has additional fields which are not included in the equality implementation, which may be incorrect.

This is a good starter bug. When fixing, please remove the corresponding entries from findbugs-filter.xml and verify the build passes.

Imported from Jira BEAM-421. Original Jira may contain additional context. Reported by: swegner.

Contributor guide

Research direction
Override equals() in CombiningValueStateTag to include its additional fields, and remove the corresponding FindBugs exclusion from findbugs filter.xml.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90