[C++][FlightRPC][ODBC] Add SQLGetInfo missing tests

Open Beginner friendly
#50,828 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
databases, testing

Research direction

Start with the existing ConnectionInfoRemoteTest tests and the ConnectionInfoHandleTest typed-test setup. Add coverage for SQL_CREATE_TABLE and SQL_CREATE_SCHEMA, checking that both return 0 for the Dremio instance. Compare remote and mock expectations and merge the tests through the typed setup if their values match.

Written by the indexing model from the issue text.

Description

Component: C++ Component: FlightRPC Type: enhancement
Describe the enhancement requested

There is a gap that 2 tests are missing from the original implementation:

  • TEST_F(ConnectionInfoRemoteTest, TestSQLGetInfoCreateTable) for SQL_CREATE_TABLE
  • TEST_F(ConnectionInfoRemoteTest, TestSQLGetInfoCreateSchema) for SQL_CREATE_SCHEMA
    If the expected value from the remote is same as the mock server, then we can merge the remote test with the mock test by using TYPED_TEST(ConnectionInfoHandleTest.

Theoretically these tests should also return 0 to signal table and schema DDL is not supported in Dremio instance. It also explains why we were only seeing inconsistencies in SQL_DROP_TABLE and SQL_DROP_SCHEMA in https://github.com/apache/arrow/issues/49482.

Component(s)

C++, FlightRPC

Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 20h
Merged PRs (30d)
95

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/arrow

All issues in apache/arrow

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.