[C++][Arrow Flight SQL ODBC] Fix value for `lpstrFilter`

Open Beginner friendly
#47,851 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
database

Research direction

Open cpp/src/arrow/flight/sql/odbc/odbc_impl/ui/dsn_configuration_window.cc at lines 569-570 and review how the ODBC file filter is defined. Update the filter to the specified wide-character value, then verify that the filter includes the terminating entries required by the issue.

Written by the indexing model from the issue text.

Description

Component: C++ Component: FlightRPC Type: enhancement
Describe the enhancement requested

From https://learn.microsoft.com/en-us/windows/win32/api/commdlg/ns-commdlg-openfilenamea:

To retrieve a shortcut's target without filtering, use the string "All Files\0*.*\0\0".

AC:

https://github.com/apache/arrow/blob/bab558061696ddc1841148d6210424b12923d48e/cpp/src/arrow/flight/sql/odbc/odbc_impl/ui/dsn_configuration_window.cc#L569-L570
In above code, replace All\0*.* with "All Files\0*.*\0\0". Since ODBC is using unicode, using the wide character string is the correct choice here. \

Parent issue: https://github.com/apache/arrow/issues/30622

Component(s)

C++, FlightRPC

Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/arrow

All issues in apache/arrow

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.