[JS] The package.json file incorrectly specifies sideEffects: false
@domoritz is already working on this.
Since Jan 5, 2024.
Assessment
This issue has not been assessed yet.
Description
Describe the bug, including details regarding any error messages, version, and platform.
Problem
When building a Node application with Webpack, calls to RecordBatchStreamWriter.toNodeStream fail with the error:
Error: "toNodeStream" not available in this environment
Cause
The apache-arrow package.json file specifies "sideEffects": false, but the Node overrides required for streaming Arrow files are applied as a side effect. I believe this is true for the DOM overrides as well.
Suggested Fix
I haven't tested this, but I think that wrapping the overrides in these two files in an IIFE as is done here will fix this issue in the Webpack build.
Component(s)
JavaScript
- Dominant language
- TypeScript
- Stars
- 112
- Forks
- 23
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/arrow-js
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100