[JDBC] Honor DriverManager login timeout

Open
#1,268 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
java
Domain
backend, database

Research direction

The entry point is ArrowFlightJdbcDriver.connect(); first read its current connection path and the existing connectTimeoutMs handling. Add coverage that sets and restores DriverManager's global timeout, checks zero and nonzero timeout behavior, SQLTimeoutException, and allocator, channel, and client cleanup when the overall attempt is cancelled or times out.

Written by the indexing model from the issue text.

Description

Describe the enhancement requested

ArrowFlightJdbcDriver.connect() does not currently honor the timeout configured through DriverManager.setLoginTimeout(int).

Implement support for the DriverManager login timeout:

  • Read the value exposed by DriverManager.getLoginTimeout() when establishing a connection selected by DriverManager.
  • Preserve the JDBC semantics of zero: do not impose a login timeout.
  • Apply a nonzero timeout to the overall connection attempt, not only the underlying Netty socket connection.
  • If the timeout expires, attempt to cancel the connection attempt and throw SQLTimeoutException.
  • Clean up any allocator, channel, or partially constructed client when the attempt is cancelled or times out.
  • Add tests that set and restore the global DriverManager timeout and verify timeout enforcement, exception type, and resource cleanup.

This is distinct from #494/#495. The existing connectTimeoutMs property configures Netty socket connection attempts and does not consume the timeout configured through DriverManager.

Context: #1027 and the follow-up discussion.

Related DataSource work: https://github.com/apache/arrow-java/issues/1267

Dominant language
Java
Stars
95
Forks
154
Avg merge
2d 16h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/arrow-java

All issues in apache/arrow-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.