apache/airflow

Tasks that are running when a DAG run reaches its timeout should optionally support `on_killed`

Open

#41,036 opened on Jul 26, 2024

View on GitHub
 (9 comments) (1 reaction) (0 assignees)Python (16,781 forks)batch import
area:Schedulergood first issuekind:feature

Repository metrics

Stars
 (44,809 stars)
PR merge metrics
 (Avg merge 7d 18h) (834 merged PRs in 30d)

Description

Description

The current functionality for task instances that are in the running state when a DAG run reaches its timeout is controversial (see #30264). It'd be great if users could optionally allow tasks' on_kill method to be called at this time.

Use case/motivation

Some users would like for externally running workloads (e.g. snowflake, emr, bigquery, etc etc) to stop executing when a DAG run times out.

Related issues

#30264

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Research direction
Examine how Airflow handles DAG run timeouts and task killing, focusing on the `on kill` callback. Investigate existing logic in `taskinstance.py` and `dagrun.py` to understand where tasks are terminated and how to optionally call `on kill` during timeout. Consider adding a configuration flag.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonAirflow internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60