apache/airflow

Fix User name and other parameters potentially containing HTLM characters

Open

#36,270 opened on Dec 17, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (44,809 stars) (16,781 forks)batch import
good first issuekind:meta

Description

Body

The User name and other parameters should be validated to not contain characters that might contain HTML-invalid characters. Also when they do, they should be escaped when rendered on HTML pages.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.

Contributor guide

Tech stack
pythonflaskhtml
Domain
securitybackend
Issue type
security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonFlaskHTML escaping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate where user names and other user supplied parameters are rendered in HTML pages in Airflow. Look at the user model and Flask templates (Jinja2). Check if there is existing validation or escaping. The fix should sanitize input to reject HTML invalid characters or ensure output is escaped using Jinja's escape filter or similar.
Fix User name and other parameters potentially containing HTLM characters · apache/airflow#36270 | Good First Issue