apache/airflow

Auto-refresh and DAG double-trigger issues when toggling pause

Open

#35,220 opened on Oct 27, 2023

View on GitHub
 (17 comments) (0 reactions) (0 assignees)Python (44,809 stars) (16,781 forks)batch import
area:coregood first issuekind:feature

Description

Apache Airflow version

2.7.2

What happened

Problems that I discovered: 1) If DAG is on pause, then when you go into it and unpause it with the button on the left, the DAG trigger turns on, but auto-update does not turn on 2) if DAG is on pause, and you turn it on with the play button (on the right ), then the dag is launched twice - as if once due to the inclusion of the dag and the second due to the activation of an already enabled dag

What you think should happen instead

After unpause DAG button auto-update should be turned on (the same behavior like after clear task)

After push play button DAG should be triggered only one time

How to reproduce

Steps to Reproduce

  1. Have a DAG on pause.
  2. Navigate to the DAG's page in the Airflow UI.
  3. Toggle the pause off using the trigger DAG button on the left.
  4. Observe that the DAG is resumed but auto-refresh is not enabled.
  5. Now, toggle the pause off using the play button on the right.
  6. Observe that the DAG is triggered twice, seemingly once for the un-pausing and once for the activation of the already resumed DAG.

Operating System

Linux from docker, and linux (rhel)

Versions of Apache Airflow Providers

No response

Deployment

Virtualenv installation

Deployment details

I think it's doesn't connected with deployment. I have the same problems in 2 different envs and also with airflow more earlier versions

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Tech stack
pythonjavascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Airflow UIBasic knowledge of ReactUnderstanding of DAG scheduling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the UI components responsible for the DAG pause and auto refresh behavior, likely in the 'airflow/ui' directory. Check the logic in the component that handles toggle events, possibly in files like 'Dag.js' or similar. Review the comments in the issue for any hints about the root cause or proposed fixes. Also look at existing tests for pause/resume functionality to understand expected behavior.
Auto-refresh and DAG double-trigger issues when toggling pause · apache/airflow#35220 | Good First Issue