apache/airflow

Include debug information in more dagbag warnings

Open

#33,853 opened on Aug 28, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (16,781 forks)batch import
good first issuekind:feature

Repository metrics

Stars
 (44,809 stars)
PR merge metrics
 (Avg merge 7d 18h) (834 merged PRs in 30d)

Description

Description

Add dag/file information to RemovedInAirflow3Warning, UserWarning, and AirflowProviderDeprecationWarning, so that a user can tell where to go to fix the issue.

Use case/motivation

Some of the RemovedInAirflow3Warnings and UserWarnings aren't actionable because i have no idea what dag they are referring to, such as:

  • RemovedInAirflow3Warning: The use of non-json-serializable params is deprecated and will be removed in a future release
  • AirflowProviderDeprecationWarning: This module is deprecated. Please use airflow.providers.cncf.kubernetes.operators.pod instead. (this one i could take an educated guess and search for pod imports, but many users wouldn't)

Some, like

  • UserWarning: The parameter waiter_countdown has been deprecated to standardize naming conventions. Please use waiter_max_attempts instead. In the future this will default to None and defer to the waiter's default value.
  • RemovedInAirflow3Warning: none_failed_or_skipped Trigger Rule is deprecated. Please use none_failed_min_one_success.

are ok because i can at least search our codebase for those keywords, but they would still be more fixable with debug info.

But even of those, its hard to find at times: for instance, when getting RemovedInAirflow3Warning: airflow.operators.python.task is deprecated. Please use the following instead there is no string i can search for without using regexes or using an IDE to find uses of the function.

Unfortunately i do know this would likely be a case-by-case fix.

Related issues

https://github.com/apache/airflow/issues/14613

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Research direction
Identify warning message calls in the Airflow codebase that lack dag/file information. For each warning, add the filename and dag id if available. Use inspect or logging calls to include source details.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70