apache/airflow

Make it possible to delete a permission from a role using the stable REST API

Open

#18,714 opened on Oct 4, 2021

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Python (16,781 forks)batch import
area:APIgood first issuekind:feature

Repository metrics

Stars
 (44,809 stars)
PR merge metrics
 (Avg merge 7d 18h) (834 merged PRs in 30d)

Description

Description

I'd like to be able to delete a permission from a role using the stable REST API. Right now, when using the PATCH verb on the /roles/{role_name} endpoint, the actions and resources combo that gets added through the body is merged into the database, making it possible to add permissions but not delete them from what I can see.

I'd like to have the option to delete a permission from a role, which I don't believe is currently possible using PATCH.

Use case/motivation

I want to be able to better modify Roles using the API. Maybe as part of CI/CD I can set up the roles to my liking by using a script which calls the API, and can change roles. Having more control over the Roles through the API would be a good feature for users of Airflow and useful specifically for my use-case involving the Astronomer platform.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Contributor guide

Research direction
Investigate how permissions are stored and how the PATCH endpoint currently merges permissions. Design a way to specify permission deletion, possibly using a new field or a DELETE method. Look at existing tests for the roles endpoint to understand the expected behavior.
Tech stack
python
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonREST API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65