antvis/Graphin

Graphin.Legend should hide node halo as well

Open

#488 opened on Jun 12, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)TypeScript (276 forks)auto 404
help wanted

Repository metrics

Stars
 (1,096 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

If the node has a halo, when we click on the legend to "hide" that node, the halo is still fully visible but it should take the node visibility into account to make it also invisible, or less visible.

Your Example Website or App

https://codesandbox.io/s/suspicious-heisenberg-rhzvzc?file=/App.tsx

Steps to Reproduce the Bug or Issue

Add a legend to a chart, display nodes with halos and click the legend to toggle node visibility.

Expected behavior

The halo should also go invisible alongside the node.

Screenshots or Videos

No response

Platform

  • OS: Linux
  • Browser: Edge, Chrome
  • Version: LTS

Additional context

No response

Contributor guide

Research direction
Investigate how the legend toggle hides nodes and identify why the halo remains visible. Look for the halo rendering logic in Graphin's source code and ensure it respects the node's visibility state.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60